-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend): rename enum SiloVersionStatus
to VersionStatus
and document the enum
#2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
requested review from
theosanderson,
fengelniederhammer and
chaoran-chen
and removed request for
fengelniederhammer
September 17, 2024 16:18
… document the enum
corneliusroemer
force-pushed
the
document-version-status
branch
from
September 17, 2024 16:19
8b58692
to
fdcd349
Compare
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/api/SubmissionTypes.kt
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/org/loculus/backend/model/ReleasedDataModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Theo Sanderson <theo@sndrsn.co.uk>
corneliusroemer
commented
Sep 17, 2024
backend/src/main/kotlin/org/loculus/backend/model/ReleasedDataModel.kt
Outdated
Show resolved
Hide resolved
corneliusroemer
commented
Sep 17, 2024
backend/src/main/kotlin/org/loculus/backend/model/ReleasedDataModel.kt
Outdated
Show resolved
Hide resolved
corneliusroemer
commented
Sep 17, 2024
backend/src/main/kotlin/org/loculus/backend/model/ReleasedDataModel.kt
Outdated
Show resolved
Hide resolved
corneliusroemer
changed the title
refactor(backend): rename enum SiloVersionStatus to VersionStatus and document the enum
refactor(backend): rename enum Sep 17, 2024
SiloVersionStatus
to VersionStatus
and document the enum
theosanderson
approved these changes
Sep 17, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawned by this Slack discussion: https://loculus.slack.com/archives/C05G172HL6L/p1726586424473839